This repository was archived by the owner on Jun 10, 2025. It is now read-only.
some improvements in PHP 7.3 compatability #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will make some time to look at this request. |
Author
|
@NorthDecoder Any news? I really changed only two lines of code so hopefully you can have a look at it soon. If you need any further input from my side please let me know. I will be happy to contribute. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's what the title says. The Theme did not run under PHP 7.3. Now it does (At least I have not run into any further errors by now.)
I haven't done any code review so far to systematically find the incompatabilities.
I promise I'll do that before I go live my site and will eventually create another pull request with the changes I might have to do then.
Best regards and many thanks for keeping the supermint theme alive :)
Andreas Sumerauer